[webkit-changes] [WebKit/WebKit] 466a83: Correctly initialize some CSS color properties.

Matthieu Dubet noreply at github.com
Tue Sep 13 14:39:48 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 466a830e85aa4a1de3a745421fa8c968196668cb
      https://github.com/WebKit/WebKit/commit/466a830e85aa4a1de3a745421fa8c968196668cb
  Author: Matthieu Dubet <m_dubet at apple.com>
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/StyleRareInheritedData.cpp
    M Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp

  Log Message:
  -----------
  Correctly initialize some CSS color properties.
https://bugs.webkit.org/show_bug.cgi?id=245138

Reviewed by Tim Nguyen.

Before this commit, those properties didn't have their own
initialization function and default-initialized to Color {},
which is an invalid color and thus is later "interpreted" as
currentcolor, correctly having an "implicit" current color behavior.
This commit makes this behavior explicit, and will allow changing the
underlying representation of "current color" in the future.

* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::initialTextStrokeColor):
(WebCore::RenderStyle::initialTextFillColor):
(WebCore::RenderStyle::initialTextEmphasisColor):
(WebCore::RenderStyle::initialTextDecorationColor):
* Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
* Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

Canonical link: https://commits.webkit.org/254458@main




More information about the webkit-changes mailing list