[webkit-changes] [WebKit/WebKit] 00a234: Always emit JavaScript signposts
bnham
noreply at github.com
Tue Sep 13 10:22:21 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 00a2349badb33cb8bccb1703920ede28bd5a8334
https://github.com/WebKit/WebKit/commit/00a2349badb33cb8bccb1703920ede28bd5a8334
Author: Ben Nham <nham at apple.com>
Date: 2022-09-13 (Tue, 13 Sep 2022)
Changed paths:
M Source/JavaScriptCore/runtime/JSGlobalObject.cpp
Log Message:
-----------
Always emit JavaScript signposts
https://bugs.webkit.org/show_bug.cgi?id=244988
<rdar://99750295>
Reviewed by Yusuke Suzuki.
In bug 244006 we conditionalized emitting os_signposts based on the DBG_APPS kdebug class. This is
not necessary for JavaScript signposts since the JS signposts are already conditionalized behind the
exposeProfilersOnGlobalObject option.
Another issue is that Instruments doesn't enable the DBG_APPS kdebug class by default, and some
members of the JSC team prefer using Instruments. This means that the JS signposts end up not being
emitted at all. Fix this by always emitting signposts from the JS API.
* Source/JavaScriptCore/runtime/JSGlobalObject.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
Canonical link: https://commits.webkit.org/254445@main
More information about the webkit-changes
mailing list