[webkit-changes] [WebKit/WebKit] a80146: Merge 254290 at main - link elements should be able t...
Ryosuke Niwa
noreply at github.com
Tue Sep 13 07:26:00 PDT 2022
Branch: refs/heads/webkitgtk/2.36
Home: https://github.com/WebKit/WebKit
Commit: a80146b15e0738c09dcade83a2789c787210a50b
https://github.com/WebKit/WebKit/commit/a80146b15e0738c09dcade83a2789c787210a50b
Author: Ryosuke Niwa <rniwa at webkit.org>
Date: 2022-09-13 (Tue, 13 Sep 2022)
Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/dom/HTMLLinkElement/link-preload-load-once-expected.txt
A LayoutTests/fast/dom/HTMLLinkElement/link-preload-load-once.html
A LayoutTests/fast/dom/HTMLLinkElement/link-stylesheet-load-once-expected.txt
A LayoutTests/fast/dom/HTMLLinkElement/link-stylesheet-load-once.html
M LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-error-events-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-load-events-expected.txt
A LayoutTests/platform/mac-wk1/fast/dom/HTMLLinkElement/link-preload-load-once-expected.txt
A LayoutTests/platform/win/fast/dom/HTMLLinkElement/link-preload-load-once-expected.txt
M Source/WebCore/html/HTMLLinkElement.cpp
M Source/WebCore/html/HTMLLinkElement.h
M Source/WebCore/html/LinkRelAttribute.h
Log Message:
-----------
Merge 254290 at main - link elements should be able to fire more than one load / error event
https://bugs.webkit.org/show_bug.cgi?id=232309
Reviewed by Darin Adler.
Based on a patch written by Chris Dumez.
This patch makes link element emit more than one load event each time resource is loaded,
and fixes the bug that setting rel content attribute to the same value resulted in the resource to be reloaded.
New behavior matches that of Chrome and Firefox.
* LayoutTests/TestExpectations: Unskip now passing tests.
* LayoutTests/fast/dom/HTMLLinkElement/link-preload-load-once-expected.txt: Added.
* LayoutTests/fast/dom/HTMLLinkElement/link-preload-load-once.html: Added.
* LayoutTests/fast/dom/HTMLLinkElement/link-stylesheet-load-once-expected.txt: Added.
* LayoutTests/fast/dom/HTMLLinkElement/link-stylesheet-load-once.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-error-events-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-load-events-expected.txt:
* LayoutTests/platform/mac-wk1/fast/dom/HTMLLinkElement/link-preload-load-once-expected.txt:
* LayoutTests/platform/win/fast/dom/HTMLLinkElement/link-preload-load-once-expected.txt:
* Source/WebCore/html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::parseAttribute):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::didFinishInsertingNode): We need to resolve URL again once this element is connected.
(WebCore::HTMLLinkElement::notifyLoadedSheetAndAllCriticalSubresources):
* Source/WebCore/html/HTMLLinkElement.h:
* Source/WebCore/html/LinkRelAttribute.h:
(WebCore::operator==): Added.
(WebCore::operator!=): Added.
Canonical link: https://commits.webkit.org/254290@main
(cherry picked from commit 3775c2edb2307598e53c311c623d3c2d7583066c)
More information about the webkit-changes
mailing list