[webkit-changes] [WebKit/WebKit] 5b6aa8: [GStreamer][WebRTC][Debug] Several tests asserting...

Philippe Normand noreply at github.com
Tue Sep 13 04:01:49 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5b6aa896a1a47904b44e56a441824f40dab808d1
      https://github.com/WebKit/WebKit/commit/5b6aa896a1a47904b44e56a441824f40dab808d1
  Author: Philippe Normand <philn at igalia.com>
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp

  Log Message:
  -----------
  [GStreamer][WebRTC][Debug] Several tests asserting in WPE bots
https://bugs.webkit.org/show_bug.cgi?id=245046

Reviewed by Xabier Rodriguez-Calvar.

Don't pass local and remote description RefPtrs to closures, because they're not
ThreadSafeRefCounted. The closures can be called from the webrtcbin PC thread, so instead keep track
of corresponding SDP description and type in separate variables.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::doSetLocalDescription):
(WebCore::GStreamerMediaEndpoint::doSetRemoteDescription):

Canonical link: https://commits.webkit.org/254428@main




More information about the webkit-changes mailing list