[webkit-changes] [WebKit/WebKit] 28ebb9: RenderScrollbarPart::computePreferredLogicalWidths...

EWS noreply at github.com
Mon Sep 12 18:03:08 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 28ebb9bd0c1e1d39a14d73c59823808e54357ba5
      https://github.com/WebKit/WebKit/commit/28ebb9bd0c1e1d39a14d73c59823808e54357ba5
  Author: Ahmad Saleem <ahmad.saleem792 at gmail.com>
  Date:   2022-09-12 (Mon, 12 Sep 2022)

  Changed paths:
    M Source/WebCore/rendering/RenderScrollbarPart.cpp
    M Source/WebCore/rendering/RenderScrollbarPart.h

  Log Message:
  -----------
  RenderScrollbarPart::computePreferredLogicalWidths is dead code

RenderScrollbarPart::computePreferredLogicalWidths is dead code
https://bugs.webkit.org/show_bug.cgi?id=106684

Reviewed by Alan Bujtas.

Patch Authored by Ojan Vafai

The layout methods never try to calculate the intrinsic or preferred widths. Also verified by adding an ASSERT_NOT_REACHED and running the layout tests as well as writing some extra tests to be sure it wasn't just a hole in the layout test coverage.

* Source/WebCore/rendering/RenderScrollbarPart.cpp:
(RenderScrollbarPart::computePreferredLogicalWidths()) - Removed
* Source/WebCore/rendering/RenderScrollbarPart.h - Removed "computePreferredLogicalWidths" function

Canonical link: https://commits.webkit.org/254417@main




More information about the webkit-changes mailing list