[webkit-changes] [WebKit/WebKit] 440d3b: [CMake] Share utilities build after 254382 at main

Don Olmstead noreply at github.com
Mon Sep 12 15:50:23 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 440d3b257da6fce84947ddd42b7db47d1200edd3
      https://github.com/WebKit/WebKit/commit/440d3b257da6fce84947ddd42b7db47d1200edd3
  Author: Don Olmstead <don.olmstead at sony.com>
  Date:   2022-09-12 (Mon, 12 Sep 2022)

  Changed paths:
    M Tools/TestWebKitAPI/CMakeLists.txt
    M Tools/TestWebKitAPI/PlatformGTK.cmake
    M Tools/TestWebKitAPI/PlatformJSCOnly.cmake
    M Tools/TestWebKitAPI/PlatformPlayStation.cmake
    M Tools/TestWebKitAPI/PlatformWPE.cmake
    M Tools/TestWebKitAPI/PlatformWin.cmake

  Log Message:
  -----------
  [CMake] Share utilities build after 254382 at main
https://bugs.webkit.org/show_bug.cgi?id=245089

Reviewed by Michael Catanzaro.

In 254382 at main all of the `TestWebKitAPI::Util` code in `Utilities.h`
was consolidated for all non-Cocoa ports. When updating the build the
ports specific implementation was just replaced with `Utilities.cpp`.
Instead of specifying it per port the `Utilities.cpp` is added to the
sources. For Cocoa ports the implementation in there is guarded with
`!PLATFORM(COCOA)` so it is safe to add it.

* Tools/TestWebKitAPI/CMakeLists.txt:
* Tools/TestWebKitAPI/PlatformGTK.cmake:
* Tools/TestWebKitAPI/PlatformJSCOnly.cmake:
* Tools/TestWebKitAPI/PlatformPlayStation.cmake:
* Tools/TestWebKitAPI/PlatformWPE.cmake:
* Tools/TestWebKitAPI/PlatformWin.cmake:

Canonical link: https://commits.webkit.org/254412@main




More information about the webkit-changes mailing list