[webkit-changes] [WebKit/WebKit] 472927: Merge 254282 at main - REGRESSION (248115 at main): `lis...

[Adrian Perez]

  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: 47292705c8da14556d2c83530bfb2777254c034f
      https://github.com/WebKit/WebKit/commit/47292705c8da14556d2c83530bfb2777254c034f
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2022-09-12 (Mon, 12 Sep 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-type-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-type-computed.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-type-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-type-valid.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-valid.html
    M Source/WebCore/css/parser/CSSPropertyParser.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.h

  Log Message:
  -----------
  Merge 254282 at main - REGRESSION (248115 at main): `list-style` shorthand property doesn't work with `inside none` but with `none inside`
https://bugs.webkit.org/show_bug.cgi?id=243991
<rdar://98748112>

Reviewed by Cameron McCormack.

none can be either list-style-type or list-style-image, and longhands can be in any order. We need to distinguish them when parsing.

Also, this fixes the bug where `none garbage` was valid, when it is actually invalid.

* LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-type-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-type-computed.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-type-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-type-valid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-valid.html:
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::consumeListStyleShorthand):
(WebCore::CSSPropertyParser::parseShorthand):
* Source/WebCore/css/parser/CSSPropertyParser.h:

Canonical link: https://commits.webkit.org/254282@main

(cherry picked from commit bf6ad141e2f3b51243013f01f5d4c30ddaeda907)


  Commit: 0c5f4fb4b6cebbf1d8be59937f3c735d233a06a0
      https://github.com/WebKit/WebKit/commit/0c5f4fb4b6cebbf1d8be59937f3c735d233a06a0
  Author: Ahmad Saleem <ahmad.saleem792 at gmail.com>
  Date:   2022-09-12 (Mon, 12 Sep 2022)

  Changed paths:
    A LayoutTests/editing/deleting/delete-button-expected.txt
    A LayoutTests/editing/deleting/delete-button.html
    M Source/WebCore/editing/DeleteSelectionCommand.cpp

  Log Message:
  -----------
  Merge 254285 at main - Deleting a button element leaves the style inside the button element
https://bugs.webkit.org/show_bug.cgi?id=94014

Reviewed by Ryosuke Niwa.

Patch Authored by - Sukolsak Sakshuwong

Make the DeleteSelectionCommand save typing style only for formattable nodes according to the HTML Editing specification and match "Blink" behavior.

* LayoutTests/editing/deleting/delete-button.html
* LayoutTests/editing/deleting/delete-button-expected.txt
* Source/WebCore/editing/DelectionSelectionCommand.cpp
(WebCore::DeleteSelectionCommand::saveTypingStyleState)

Canonical link: https://commits.webkit.org/254285@main

(cherry picked from commit c75ccbd4e966b91f06494b79f42403fe3a0bcafb)


Compare: https://github.com/WebKit/WebKit/compare/db85acc96b85...0c5f4fb4b6ce