[webkit-changes] [WebKit/WebKit] f8712d: AX: Remove 20 live-tree-only methods from the AXCo...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f8712d179a82c559c83b86ca342b21786a976f92
      https://github.com/WebKit/WebKit/commit/f8712d179a82c559c83b86ca342b21786a976f92
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2022-09-12 (Mon, 12 Sep 2022)

  Changed paths:
    M Source/WebCore/accessibility/AXImage.h
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/AccessibilityAttachment.h
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityNodeObject.h
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/AccessibilityObjectInterface.h
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/accessibility/AccessibilityRenderObject.h
    M Source/WebCore/accessibility/AccessibilitySVGElement.h
    M Source/WebCore/accessibility/AccessibilitySVGRoot.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h

  Log Message:
  -----------
  AX: Remove 20 live-tree-only methods from the AXCoreObject interface
https://bugs.webkit.org/show_bug.cgi?id=245039
rdar://problem/99785433

Reviewed by Andres Gonzalez.

This patch also:
  - Removes some dead functions.
  - Makes some AccessibilityObject functions non-virtual (because they
    were unncessarily virtual before), which will provide a minor
    performance improvement.

* Source/WebCore/accessibility/AXImage.h:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::characterOffsetFromVisiblePosition):
(WebCore::AXObjectCache::indexForCharacterOffset): Deleted.
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityAttachment.h:
(isType):
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isImageButton const): Deleted.
(WebCore::AccessibilityNodeObject::passwordFieldOrContainingPasswordField): Deleted.
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::lengthForVisiblePositionRange const): Deleted.
(WebCore::AccessibilityObject::visiblePositionForBounds const): Deleted.
(WebCore::AccessibilityObject::nextWordEnd const): Deleted.
(WebCore::AccessibilityObject::previousWordStart const): Deleted.
(WebCore::AccessibilityObject::accessibilityObjectForPosition const): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isAccessibilitySVGRoot const):
(WebCore::AccessibilityObject::isAttachmentElement const):
* Source/WebCore/accessibility/AccessibilityObjectInterface.h:
(WebCore::AXCoreObject::isVideo const):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::linkClickPoint):
(WebCore::AccessibilityRenderObject::remoteSVGRootElement const):
(WebCore::AccessibilityRenderObject::lineBreaks const): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.h:
* Source/WebCore/accessibility/AccessibilitySVGElement.h:
(): Deleted.
* Source/WebCore/accessibility/AccessibilitySVGRoot.h:
(isType):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::lengthForVisiblePositionRange const): Deleted.
(WebCore::AXIsolatedObject::visiblePositionForBounds const): Deleted.
(WebCore::AXIsolatedObject::nextVisiblePosition const): Deleted.
(WebCore::AXIsolatedObject::previousVisiblePosition const): Deleted.
(WebCore::AXIsolatedObject::nextWordEnd const): Deleted.
(WebCore::AXIsolatedObject::previousWordStart const): Deleted.
(WebCore::AXIsolatedObject::accessibilityObjectForPosition const): Deleted.
(WebCore::AXIsolatedObject::lineBreaks const): Deleted.
(WebCore::AXIsolatedObject::isAXImageInstance const): Deleted.
(WebCore::AXIsolatedObject::isAccessibilitySVGRoot const): Deleted.
(WebCore::AXIsolatedObject::isAccessibilitySVGElement const): Deleted.
(WebCore::AXIsolatedObject::isAttachmentElement const): Deleted.
(WebCore::AXIsolatedObject::isNativeImage const): Deleted.
(WebCore::AXIsolatedObject::isImageButton const): Deleted.
(WebCore::AXIsolatedObject::isContainedByPasswordField const): Deleted.
(WebCore::AXIsolatedObject::passwordFieldOrContainingPasswordField): Deleted.
(WebCore::AXIsolatedObject::isFigureElement const): Deleted.
(WebCore::AXIsolatedObject::hasDatalist const): Deleted.
(WebCore::AXIsolatedObject::isModalDescendant const): Deleted.
(WebCore::AXIsolatedObject::accessibleNameDerivesFromContent const): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:

Canonical link: https://commits.webkit.org/254395@main