[webkit-changes] [WebKit/WebKit] e30caa: Handling of text documents does not comply with mo...

Brent Fulgham noreply at github.com
Mon Sep 12 09:55:54 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e30caa272fe6d8f18f34521fe30ef5c9d97125a8
      https://github.com/WebKit/WebKit/commit/e30caa272fe6d8f18f34521fe30ef5c9d97125a8
  Author: Brent Fulgham <bfulgham at apple.com>
  Date:   2022-09-12 (Mon, 12 Sep 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_putall.tentative.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_putall.tentative.any.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/read-text/load-text-plain-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/global/value-set.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/global/value-set.any.worker-expected.txt
    M LayoutTests/platform/glib/fast/loader/text-document-wrapping-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.https.worker-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/wasm/jsapi/global/value-set.any-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/wasm/jsapi/global/value-set.any.worker-expected.txt
    M LayoutTests/platform/gtk/fast/forms/targeted-frame-submission-expected.txt
    M LayoutTests/platform/ios-wk2/fast/forms/targeted-frame-submission-expected.txt
    M LayoutTests/platform/ios-wk2/fast/loader/text-document-wrapping-expected.txt
    M LayoutTests/platform/ios/fast/forms/targeted-frame-submission-expected.txt
    M LayoutTests/platform/ios/fast/loader/text-document-wrapping-expected.txt
    M LayoutTests/platform/mac/fast/forms/targeted-frame-submission-expected.txt
    M LayoutTests/platform/mac/fast/loader/text-document-wrapping-expected.txt
    M LayoutTests/platform/mac/http/tests/misc/acid3-expected.txt
    M LayoutTests/platform/win/fast/loader/text-document-wrapping-expected.txt
    M LayoutTests/platform/wincairo/fast/loader/text-document-wrapping-expected.txt
    M Source/WebCore/html/TextDocument.cpp

  Log Message:
  -----------
  Handling of text documents does not comply with modern HTML spec
https://bugs.webkit.org/show_bug.cgi?id=244950
<rdar://problem/99719728>

Reviewed by Chris Dumez.

The spec language in https://html.spec.whatwg.org/multipage/browsing-the-web.html#read-text, indicates that Text documents
must be in no-quirks mode: (7.11.4.3 Set document's mode to "no-quirks".)

This is in conflict with the source code in the TextDocument constructor:

  setCompatibilityMode(DocumentCompatibilityMode::QuirksMode);

This causes the following WPT failure:

wpt /html/browsers/browsing-the-web/read-text/load-text-plain.html

* LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/read-text/load-text-plain-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_putall.tentative.any-expected.txt
* LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_putall.tentative.any.worker-expected.txt
* LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/global/value-set.any-expected.txt
* LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/global/value-set.any.worker-expected.txt
* LayoutTests/platform/glib/fast/loader/text-document-wrapping-expected.txt
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.https.worker-expected.txt
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/wasm/jsapi/global/value-set.any-expected.txt
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/wasm/jsapi/global/value-set.any.worker-expected.txt
* LayoutTests/platform/gtk/fast/forms/targeted-frame-submission-expected.txt
* LayoutTests/platform/ios-wk2/fast/forms/targeted-frame-submission-expected.txt
* LayoutTests/platform/ios-wk2/fast/loader/text-document-wrapping-expected.txt
* LayoutTests/platform/ios/fast/forms/targeted-frame-submission-expected.txt
* LayoutTests/platform/ios/fast/loader/text-document-wrapping-expected.txt
* LayoutTests/platform/mac/fast/forms/targeted-frame-submission-expected.txt
* LayoutTests/platform/mac/fast/loader/text-document-wrapping-expected.txt
* LayoutTests/platform/mac/http/tests/misc/acid3-expected.txt
* LayoutTests/platform/win/fast/loader/text-document-wrapping-expected.txt
* LayoutTests/platform/wincairo/fast/loader/text-document-wrapping-expected.txt
* Source/WebCore/html/TextDocument.cpp:

Canonical link: https://commits.webkit.org/254389@main




More information about the webkit-changes mailing list