[webkit-changes] [WebKit/WebKit] ee1be4: Revision field in the json data generated by run-w...

[Carlos Alberto Lopez Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ee1be476e83b744d0d91887b48953cb2552fcfc0
      https://github.com/WebKit/WebKit/commit/ee1be476e83b744d0d91887b48953cb2552fcfc0
  Author: Carlos Alberto Lopez Perez <clopez at igalia.com>
  Date:   2022-09-12 (Mon, 12 Sep 2022)

  Changed paths:
    M Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
    M Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py

  Log Message:
  -----------
  Revision field in the json data generated by run-webkit-tests is empty since migration to git
https://bugs.webkit.org/show_bug.cgi?id=244960

Reviewed by Jonathan Bedard.

The script run-webkit-tests generates a json file with the information of
the test run (usually named full_results.json).

This json included a "revision" field with the SVN revision of the checkout.
But since the migration to git this "revision" field is null.

Fix it by setting as revision number the canonical identifier "number at main"
if available, otherwise default to the git commit hash.

* Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py:
(summarize_results):
* Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
(SummarizedResultsTest.test_no_git_revision):
(SummarizedResultsTest.test_git_revision_exists):
(SummarizedResultsTest.test_git_revision_identifier):
(SummarizedResultsTest.test_no_svn_revision): Deleted.
(SummarizedResultsTest.test_svn_revision_exists): Deleted.
(SummarizedResultsTest.test_svn_revision): Deleted.
(SummarizedResultsTest.test_svn_revision_git): Deleted.

Canonical link: https://commits.webkit.org/254376@main