[webkit-changes] [WebKit/WebKit] ebdff2: Incorrect image srcset candidate chosen for <img> ...

Ryosuke Niwa noreply at github.com
Sat Sep 10 21:17:41 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ebdff21ed51676ee81de66302692042d5bf8d6c4
      https://github.com/WebKit/WebKit/commit/ebdff21ed51676ee81de66302692042d5bf8d6c4
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2022-09-10 (Sat, 10 Sep 2022)

  Changed paths:
    A LayoutTests/fast/images/hidpi-img-cloned-from-template-expected.html
    A LayoutTests/fast/images/hidpi-img-cloned-from-template.html
    A LayoutTests/fast/images/hidpi-img-from-dom-parser-expected.html
    A LayoutTests/fast/images/hidpi-img-from-dom-parser.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/adoption-expected.txt
    R LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/adoption-expected.txt
    M Source/WebCore/html/HTMLImageElement.cpp

  Log Message:
  -----------
  Incorrect image srcset candidate chosen for <img> cloned from <template>
https://bugs.webkit.org/show_bug.cgi?id=211620

Reviewed by Simon Fraser.

The bug was caused by HTMLImageElement not selecting the correct candidate
if it was initially created in a document without a browsing context.

* LayoutTests/fast/images/hidpi-img-cloned-from-template-expected.html: Added.
* LayoutTests/fast/images/hidpi-img-cloned-from-template.html: Added.
* LayoutTests/fast/images/hidpi-img-from-dom-parser-expected.html: Added.
* LayoutTests/fast/images/hidpi-img-from-dom-parser.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/adoption-expected.txt:
  Rebaselined now that all test cases are passing.
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/adoption-expected.txt: Removed.

* Source/WebCore/html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::didMoveToNewDocument):

Canonical link: https://commits.webkit.org/254361@main




More information about the webkit-changes mailing list