[webkit-changes] [WebKit/WebKit] eda885: Webshare API Level 2 "Save Image" not resolving th...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eda885f3f2818f11263b12c184786494fce81f09
      https://github.com/WebKit/WebKit/commit/eda885f3f2818f11263b12c184786494fce81f09
  Author: Tim Horton <timothy_horton at apple.com>
  Date:   2022-09-09 (Fri, 09 Sep 2022)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm

  Log Message:
  -----------
  Webshare API Level 2 "Save Image" not resolving the navigator in IOS 15
https://bugs.webkit.org/show_bug.cgi?id=231995
<rdar://84467461>

Reviewed by Wenson Hsieh.

* Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm:
(-[WKShareSheet presentWithShareDataArray:inRect:]):
Depending on the action chosen, the final `completionWithItems` callback
can come either after the UIActivityViewController is no longer presented,
or while it's being dismissed.

The current implementation only covers the first case; if we get the callback
during the dismissal, we will never call our completion handler, and never
unblock navigator.share.

In order to keep avoid regressing our fixes from both 227713 at main and 229913 at main
in the case where we are called back during dismissal, call the completion
handler in that case as well.

Canonical link: https://commits.webkit.org/254346@main