[webkit-changes] [WebKit/WebKit] b6660d: Refactor "had element child" determination logic i...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b6660d9ce55e552c8bfc06e4f7ac07b5e7e9b70d
      https://github.com/WebKit/WebKit/commit/b6660d9ce55e552c8bfc06e4f7ac07b5e7e9b70d
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2022-09-09 (Fri, 09 Sep 2022)

  Changed paths:
    M Source/WebCore/dom/ContainerNode.cpp
    M Source/WebCore/dom/ContainerNode.h
    M Source/WebCore/html/HTMLSelectElement.cpp

  Log Message:
  -----------
  Refactor "had element child" determination logic in ContainerNode::removeAllChildrenWithScriptAssertion
https://bugs.webkit.org/show_bug.cgi?id=244732
rdar://99506128

Reviewed by Chris Dumez.

* Source/WebCore/dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeAllChildrenWithScriptAssertion):

Refactor logic to compute `hadElementChild` in a single place.

* Source/WebCore/dom/ContainerNode.h:

Introduce an `Unknown` value, as `ChildChange` is passed into
`ChildChangeInvalidation` prior to the `hadElementChild` computation. While
the value of `affectsElements` is not read in `ChildChangeInvalidation`,
use the `Unknown` value to make the current behavior explicit.

* Source/WebCore/html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childrenChanged):

Canonical link: https://commits.webkit.org/254331@main