[webkit-changes] [WebKit/WebKit] bbe48e: [macOS] <attachment> should not use a generic file...

Devin Rousso noreply at github.com
Fri Sep 9 11:43:13 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bbe48e2484b733e443259c8feecd9dddbcd35285
      https://github.com/WebKit/WebKit/commit/bbe48e2484b733e443259c8feecd9dddbcd35285
  Author: Devin Rousso <drousso at apple.com>
  Date:   2022-09-09 (Fri, 09 Sep 2022)

  Changed paths:
    M Source/WebCore/rendering/RenderThemeMac.mm

  Log Message:
  -----------
  [macOS] <attachment> should not use a generic file icon for iWork files
https://bugs.webkit.org/show_bug.cgi?id=244948
<rdar://problem/99719478>

Reviewed by Tim Horton.

* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::iconForAttachment):
Only use the given `attachmentType` if it's not `"public.data"`, as that's the fallback value. If it
is `"public.data"`, attempt to derive an icon from the filename and/or extension before using it.

Canonical link: https://commits.webkit.org/254315@main




More information about the webkit-changes mailing list