[webkit-changes] [WebKit/WebKit] c2800d: Support importing compressed EC keys in webcrypto

EWS noreply at github.com
Fri Sep 9 10:43:38 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2800dd46bb2deeea08659eb0d3ae6d9eab219ac
      https://github.com/WebKit/WebKit/commit/c2800dd46bb2deeea08659eb0d3ae6d9eab219ac
  Author: Angela Izquierdo Garcia <aizquierdogarcia at apple.com>
  Date:   2022-09-09 (Fri, 09 Sep 2022)

  Changed paths:
    A LayoutTests/crypto/subtle/ecdsa-import-compressed-spki-key-p384-expected.txt
    A LayoutTests/crypto/subtle/ecdsa-import-compressed-spki-key-p384.html
    A LayoutTests/crypto/subtle/ecdsa-import-compressed-spki-key-p384.txt
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/PAL/pal/spi/cocoa/CommonCryptoSPI.h
    M Source/WebCore/crypto/mac/CryptoKeyECMac.cpp

  Log Message:
  -----------
  Support importing compressed EC keys in webcrypto
https://bugs.webkit.org/show_bug.cgi?id=244032
rdar://86211772

Reviewed by Youenn Fablet

The compressed point format includes the least significant bit of the second coordinates in the first byte to know the orientation , so that is why the index is incremented one unit when dealing with compressed curves .  Otherwise the function ccec_compact_import_pub_size receivesthe wrong number, expecting always a number greater in just one unit.
* LayoutTests/crypto/subtle/ecdsa-import-compressed-spki-key-p384-expected.txt: Added.
* LayoutTests/crypto/subtle/ecdsa-import-compressed-spki-key-p384.html: Added.
* LayoutTests/crypto/subtle/ecdsa-import-compressed-spki-key-p384.txt: Added.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/PAL/pal/spi/cocoa/CommonCryptoSPI.h:
* Source/WebCore/crypto/mac/CryptoKeyECMac.cpp:
(WebCore::CryptoKeyEC::platformImportSpki):

Canonical link: https://commits.webkit.org/254310@main




More information about the webkit-changes mailing list