[webkit-changes] [WebKit/WebKit] 79531d: [LFC][IFC] Fix fast/lists/list-marker-before-float...

alan noreply at github.com
Fri Sep 9 09:59:12 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 79531d096293b0b89b2e1d08b2f713e42e2b1b2a
      https://github.com/WebKit/WebKit/commit/79531d096293b0b89b2e1d08b2f713e42e2b1b2a
  Author: Alan Bujtas <zalan at apple.com>
  Date:   2022-09-09 (Fri, 09 Sep 2022)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h

  Log Message:
  -----------
  [LFC][IFC] Fix fast/lists/list-marker-before-float-nested.html
https://bugs.webkit.org/show_bug.cgi?id=244912

Reviewed by Antti Koivisto.

'outside' list marker should not only be placed outside of the line box, but it should also avoid floats on the line.
Let's compute the line box offset (normally 0) which is the distance between the initial line (logical) left and the left side of the final line box (floats, text-indent etc).

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h:
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::build):
(WebCore::Layout::InlineDisplayContentBuilder::outsideListMarkerVisualPosition const):
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:

Canonical link: https://commits.webkit.org/254305@main




More information about the webkit-changes mailing list