[webkit-changes] [WebKit/WebKit] f6198c: [GTK][WPE] Use a single xdg-dbus-proxy process

Carlos Garcia Campos noreply at github.com
Fri Sep 9 01:05:23 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f6198cdad380b68e02c7a135b18fcf7e387078ea
      https://github.com/WebKit/WebKit/commit/f6198cdad380b68e02c7a135b18fcf7e387078ea
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2022-09-09 (Fri, 09 Sep 2022)

  Changed paths:
    M Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp
    M Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp
    M Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.h

  Log Message:
  -----------
  [GTK][WPE] Use a single xdg-dbus-proxy process
https://bugs.webkit.org/show_bug.cgi?id=244930

Reviewed by Michael Catanzaro.

We currently spawn two xdg-dbus-proxy processes, one for the session bus
and one for the atspi bus, but we can do both with a single process.

* Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::bindDBusSession): Receive the XDGDBusProxy as argument. Use the
new api to get the proxy paths.
(WebKit::bindA11y): Ditto.
(WebKit::bubblewrapSpawn): Create a single XDGDBusProxy and pass it to bindDBusSession() and bindA11y().
* Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp:
(WebKit::XDGDBusProxy::makePath): Helper to create a path for the given DBus address.
(WebKit::XDGDBusProxy::makeProxy): Helper to create the proxy file using the given template.
(WebKit::XDGDBusProxy::dbusSessionProxy): Return the proxy paths for DBus session.
(WebKit::XDGDBusProxy::accessibilityProxy): Return the proxy paths for atspi.
(WebKit::XDGDBusProxy::launch): Return falseif we don't need to spawn xdg-dbus-proxy at all.
(WebKit::XDGDBusProxy::XDGDBusProxy): Deleted.
(WebKit::XDGDBusProxy::~XDGDBusProxy): Deleted.
(WebKit::XDGDBusProxy::makeProxy const): Deleted.
(WebKit::XDGDBusProxy::launch const): Deleted.
* Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.h:
(WebKit::XDGDBusProxy::proxyPath const): Deleted.
(WebKit::XDGDBusProxy::path const): Deleted.
(): Deleted.

Canonical link: https://commits.webkit.org/254293@main




More information about the webkit-changes mailing list