[webkit-changes] [WebKit/WebKit] 7c5cd0: REGRESSION (254104 at main): [Reporting API] Do not e...

Brent Fulgham noreply at github.com
Wed Sep 7 23:34:48 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7c5cd05f49f96c9294e344cf8eebee9e97df3f13
      https://github.com/WebKit/WebKit/commit/7c5cd05f49f96c9294e344cf8eebee9e97df3f13
  Author: Brent Fulgham <bfulgham at apple.com>
  Date:   2022-09-07 (Wed, 07 Sep 2022)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/Modules/reporting/ReportingScope.cpp
    M Source/WebCore/Modules/reporting/TestReportBody.cpp
    M Source/WebCore/Modules/reporting/TestReportBody.idl
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj

  Log Message:
  -----------
  REGRESSION (254104 at main): [Reporting API] Do not expose TestReportBody as a JS-exposed type
https://bugs.webkit.org/show_bug.cgi?id=244905
<rdar://problem/99664743>

Reviewed by Chris Dumez.

I mistakenly treated TestReportBody as a public JS type that could be exposed to the web and created by JS code.
This isn't correct. TestReportBody is just a class-cluster implementation behind ReportBody, and should not itself
be exposed (just the generic ReportBody type).

This patch fixes that error.

* LayoutTests/TestExpectations: Mark a flaky test (Drive-by fix)
* Source/WebCore/Modules/reporting/ReportingScope.cpp:
(WebCore::ReportingScope::generateTestReport): Add reminder to fix a bug in test reports.
* Source/WebCore/Modules/reporting/TestReportBody.cpp: Drive-by fix (whitespace).
* Source/WebCore/Modules/reporting/TestReportBody.idl: Stop exposing the class to the JS layer.
* Source/WebCore/WebCore.xcodeproj/project.pbxproj: Remove some incorrect generated files,
and add some missed ones.

Canonical link: https://commits.webkit.org/254261@main




More information about the webkit-changes mailing list