[webkit-changes] [WebKit/WebKit] 28a89f: Merge 254232 at main - [WPE][GTK] web-process-termina...

[Carlos Garcia Campos]

  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: 28a89facb87206b6a2148565e81b4d1cd4024710
      https://github.com/WebKit/WebKit/commit/28a89facb87206b6a2148565e81b4d1cd4024710
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2022-09-07 (Wed, 07 Sep 2022)

  Changed paths:
    M Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp
    M Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp

  Log Message:
  -----------
  Merge 254232 at main - [WPE][GTK] web-process-terminated signal not emitted for first web view when bubblewrap sandbox is enabled
https://bugs.webkit.org/show_bug.cgi?id=221489

Reviewed by Michael Catanzaro.

We run all subprocesses with G_SUBPROCESS_FLAGS_INHERIT_FDS. Since
xdg-dbus-proxy is spawned right before the first web process, but after
the socketpair for the web process has been called, it's inheriting the
connected socket. When the first web process dies, the connection is
still connected from the UI process to the xdg-dbus-proxy process, and
hup signal is not emitted. I think we don't need to use
G_SUBPROCESS_FLAGS_INHERIT_FDS, because we are already using
g_subprocess_launcher_take_fd() to transfer the fds we want.

* Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:
(WebKit::ProcessLauncher::launchProcess):
* Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp:
(WebKit::XDGDBusProxy::launch const):

Canonical link: https://commits.webkit.org/254232@main

(cherry picked from commit 63e2970f0f1bfa8e5ecf59cb029566c7d0bc78e2)