[webkit-changes] [WebKit/WebKit] 3bd991: [Revert]: (253931 at main): [ macOS wk1 Debug ] media...

Karl Rackler noreply at github.com
Wed Sep 7 10:47:30 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3bd99112f8a9d51a38a5880d7f51fed3f73bafc1
      https://github.com/WebKit/WebKit/commit/3bd99112f8a9d51a38a5880d7f51fed3f73bafc1
  Author: Karl Rackler <rackler at apple.com>
  Date:   2022-09-07 (Wed, 07 Sep 2022)

  Changed paths:
    M LayoutTests/TestExpectations
    R LayoutTests/media/track/captions-webvtt/captions-descriptions.vtt
    R LayoutTests/media/track/track-description-cue-expected.txt
    R LayoutTests/media/track/track-description-cue.html
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac-wk1/TestExpectations
    M LayoutTests/platform/mac/TestExpectations
    M Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
    M Source/WebCore/Modules/speech/SpeechSynthesis.cpp
    M Source/WebCore/Modules/speech/SpeechSynthesis.h
    M Source/WebCore/Modules/speech/SpeechSynthesisUtterance.cpp
    M Source/WebCore/Modules/speech/SpeechSynthesisUtterance.h
    M Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/html/HTMLMediaElement.h
    M Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp
    M Source/WebCore/html/track/InbandGenericTextTrack.cpp
    M Source/WebCore/html/track/TextTrack.cpp
    M Source/WebCore/html/track/TextTrack.h
    M Source/WebCore/html/track/TextTrackCue.cpp
    M Source/WebCore/html/track/TextTrackCue.h
    M Source/WebCore/html/track/VTTCue.cpp
    M Source/WebCore/html/track/VTTCue.h
    M Source/WebCore/html/track/VTTCue.idl
    M Source/WebCore/page/CaptionUserPreferences.cpp
    M Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp
    M Source/WebCore/page/CaptionUserPreferencesMediaAF.h
    M Source/WebCore/platform/cf/MediaAccessibilitySoftLink.cpp
    M Source/WebCore/platform/cf/MediaAccessibilitySoftLink.h
    M Source/WebCore/platform/cocoa/PlatformSpeechSynthesizerCocoa.mm
    M Source/WebCore/platform/graphics/InbandGenericCue.cpp
    M Source/WebCore/platform/graphics/iso/ISOVTTCue.cpp
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  [Revert]: (253931 at main): [ macOS wk1 Debug ] media/track/track-description-cue.html consistently hits ASSERTION FAILED: !m_currentSpeechUtterance
https://bugs.webkit.org/show_bug.cgi?id=244683
rdar://problem/99449962

Unreviewed revert
This reverts 253931 at main because it consistently hits ASSERTION FAILED: !m_currentSpeechUtterance.

* LayoutTests/TestExpectations:
* LayoutTests/media/track/captions-webvtt/captions-descriptions.vtt: Removed.
* LayoutTests/media/track/track-description-cue-expected.txt: Removed.
* LayoutTests/media/track/track-description-cue.html: Removed.
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
* Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:
* Source/WebCore/Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::fireEvent const):
(WebCore::SpeechSynthesis::fireErrorEvent const):
(WebCore::SpeechSynthesis::handleSpeakingCompleted):
(WebCore::SpeechSynthesis::boundaryEventOccurred):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didPauseSpeaking):
(WebCore::SpeechSynthesis::didResumeSpeaking):
* Source/WebCore/Modules/speech/SpeechSynthesis.h:
(WebCore::SpeechSynthesis::userGestureRequiredForSpeechStart const):
(WebCore::SpeechSynthesis::removeBehaviorRestriction):
* Source/WebCore/Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore::SpeechSynthesisUtterance::create):
(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::eventOccurred): Deleted.
(WebCore::SpeechSynthesisUtterance::errorEventOccurred): Deleted.
* Source/WebCore/Modules/speech/SpeechSynthesisUtterance.h:
(): Deleted.
* Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::m_categoryAtMostRecentPlayback):
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
(WebCore::HTMLMediaElement::seekWithTolerance):
(WebCore::HTMLMediaElement::seekTask):
(WebCore::HTMLMediaElement::finishSeek):
(WebCore::HTMLMediaElement::addTextTrack):
(WebCore::HTMLMediaElement::configureTextTrackGroup):
(WebCore::HTMLMediaElement::playPlayer):
(WebCore::HTMLMediaElement::pausePlayer):
(WebCore::HTMLMediaElement::captionPreferencesChanged):
(WebCore::HTMLMediaElement::effectiveVolume const):
(WebCore::m_logIdentifier): Deleted.
* Source/WebCore/html/HTMLMediaElement.h:
* Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
* Source/WebCore/html/track/InbandGenericTextTrack.cpp:
* Source/WebCore/html/track/TextTrack.cpp:
(WebCore::TextTrack::trackIndex):
(WebCore::TextTrack::isRendered):
(WebCore::TextTrack::trackIndexRelativeToRenderedTracks):
(WebCore::TextTrack::isSpoken): Deleted.
(WebCore::TextTrack::speechSynthesis): Deleted.
* Source/WebCore/html/track/TextTrack.h:
* Source/WebCore/html/track/TextTrackCue.cpp:
(WebCore::operator<<):
* Source/WebCore/html/track/TextTrackCue.h:
(WebCore::TextTrackCue::text const): Deleted.
(WebCore::TextTrackCue::speak): Deleted.
* Source/WebCore/html/track/VTTCue.cpp:
(WebCore::VTTCue::updateDisplayTree):
(WebCore::VTTCue::getDisplayTree):
(WebCore::VTTCue::toJSON const):
(WebCore::VTTCue::speak): Deleted.
* Source/WebCore/html/track/VTTCue.h:
(WebCore::VTTCue::text const):
(WebCore::VTTCue::speechUtterance const): Deleted.
* Source/WebCore/html/track/VTTCue.idl:
* Source/WebCore/page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::userPrefersTextDescriptions const):
(WebCore::CaptionUserPreferences::textTrackSelectionScore const):
* Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::userPrefersCaptions const):
(WebCore::CaptionUserPreferencesMediaAF::userPrefersTextDescriptions const): Deleted.
* Source/WebCore/page/CaptionUserPreferencesMediaAF.h:
* Source/WebCore/platform/cf/MediaAccessibilitySoftLink.cpp:
* Source/WebCore/platform/cf/MediaAccessibilitySoftLink.h:
* Source/WebCore/platform/cocoa/PlatformSpeechSynthesizerCocoa.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:]):
* Source/WebCore/platform/graphics/InbandGenericCue.cpp:
(WebCore::InbandGenericCue::toJSONString const):
* Source/WebCore/platform/graphics/iso/ISOVTTCue.cpp:
(WebCore::ISOWebVTTCue::toJSONString const):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::setMediaElementVolumeLocked):
(WebCore::Internals::speechSynthesisUtteranceForCue): Deleted.
(WebCore::Internals::mediaElementCurrentlySpokenCue): Deleted.
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::speechSynthesisSpeak):

Canonical link: https://commits.webkit.org/254241@main




More information about the webkit-changes mailing list