[webkit-changes] [WebKit/WebKit] 0ddb0c: Stop calling NSDisableScreenUpdates()/NSEnableScre...

Simon Fraser noreply at github.com
Wed Sep 7 10:01:37 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0ddb0cb7d5bb36bdfc89e6078c18094ccd583c62
      https://github.com/WebKit/WebKit/commit/0ddb0cb7d5bb36bdfc89e6078c18094ccd583c62
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2022-09-07 (Wed, 07 Sep 2022)

  Changed paths:
    M Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm
    M Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm

  Log Message:
  -----------
  Stop calling NSDisableScreenUpdates()/NSEnableScreenUpdates()
https://bugs.webkit.org/show_bug.cgi?id=244755

Reviewed by Tim Horton.

NSDisableScreenUpdates()/NSEnableScreenUpdates() are no-ops for applications linked on Catalina or later.

We call these when showing/hiding the fullscreen window, which is UI that webkit controls, so it should be safe to remove
calls to these functions.

* Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):
* Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm:
(-[WebFullScreenController enterFullScreen:]):
(-[WebFullScreenController finishedEnterFullScreenAnimation:]):
(-[WebFullScreenController exitFullScreen]):
(-[WebFullScreenController finishedExitFullScreenAnimation:]):
(-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
(-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):

Canonical link: https://commits.webkit.org/254239@main




More information about the webkit-changes mailing list