[webkit-changes] [WebKit/WebKit] af6020: WebM file fail to play

Jean-Yves Avenard noreply at github.com
Wed Sep 7 02:32:08 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: af6020b7b7f9b44ef5db6c7b77c54251b25a0a68
      https://github.com/WebKit/WebKit/commit/af6020b7b7f9b44ef5db6c7b77c54251b25a0a68
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2022-09-07 (Wed, 07 Sep 2022)

  Changed paths:
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm

  Log Message:
  -----------
  WebM file fail to play
https://bugs.webkit.org/show_bug.cgi?id=242854
<rdar://97190939>

Reviewed by Eric Carlson.

If a track is disabled because it contains no data, the AV MediaPlayer will
flag the content as not playable even though it will play.

We can't properly test this change for the failing file as we rely on the
MediaFormatReader plugin to decode WebM which isn't available on the EWS bots.

* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::allTracksArePlayable const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::containsDisabledTracks const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus const):

Canonical link: https://commits.webkit.org/254219@main




More information about the webkit-changes mailing list