[webkit-changes] [WebKit/WebKit] e347e3: Allow ad-hoc code signing for TestWebKitAPI and We...

[Elliott Williams]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e347e3e762ae6078618689646e69c9d4aca2e152
      https://github.com/WebKit/WebKit/commit/e347e3e762ae6078618689646e69c9d4aca2e152
  Author: Elliott Williams <emw at apple.com>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M Tools/TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements
    M Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig
    A Tools/WebKitTestRunner/Configurations/WebKitTestRunner-internal.entitlements
    M Tools/WebKitTestRunner/Configurations/WebKitTestRunner.entitlements
    M Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig

  Log Message:
  -----------
  Allow ad-hoc code signing for TestWebKitAPI and WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=242730

Reviewed by Alexey Proskuryakov.

Xcode 14 requires a signing identity when building command-line tools.
Internal builds already use a custom signing identity
(WK_ENGINEERING_CODE_SIGN_IDENTITY). Change the default identity for
open-source builds to ad-hoc ("-").

* Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
* Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:

Prior to this change, EWS was not signing these binaries with
entitlements, even though we declare them. It turns out that many of the
entitlements we declare require a valid signing identity. While the
long-term solution might be to give all EWS machines a proper signing
identity (and ask contributors to do the same), we can remove these
entitlements from open-source builds for now. Tests that depend on the
entitlements' capabilities will fail, but they were already failing.

* Tools/TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
  TestWebKitAPI already has a "TestWebKitAPI-macOS-internal.entitlements"
  file. Remove internal-only entitlements from this file.
* Tools/WebKitTestRunner/Configurations/WebKitTestRunner-internal.entitlements: Copied from Tools/WebKitTestRunner/Configurations/WebKitTestRunner.entitlements.
* Tools/WebKitTestRunner/Configurations/WebKitTestRunner.entitlements:
  Remove internal-only entitlements.

Canonical link: https://commits.webkit.org/254192@main