[webkit-changes] [WebKit/WebKit] 9952b5: [LFC][IFC] FloatingContext::constraints should sup...

alan noreply at github.com
Tue Sep 6 07:32:32 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9952b530ddd2d6d6fb4a6384554f12cdddf1e356
      https://github.com/WebKit/WebKit/commit/9952b530ddd2d6d6fb4a6384554f12cdddf1e356
  Author: Alan Bujtas <zalan at apple.com>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M Source/WebCore/layout/floats/FloatingContext.cpp
    M Source/WebCore/layout/floats/FloatingContext.h
    M Source/WebCore/layout/floats/FloatingState.h
    M Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp

  Log Message:
  -----------
  [LFC][IFC] FloatingContext::constraints should support cases when not just the last (inner most) float counts
https://bugs.webkit.org/show_bug.cgi?id=244790

Reviewed by Antti Koivisto.

While finding the next float position in a BFC only requires to look at the inner most (last) floats, in IFC when floats are placed to subsequent lines (overflowing floats), the last float is not necessarily the only constraint at a particular vertical position.

* Source/WebCore/layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::constraints const):
* Source/WebCore/layout/floats/FloatingContext.h:
* Source/WebCore/layout/floats/FloatingState.h:
(WebCore::Layout::FloatingState::FloatItem::isRightPositioned const):
* Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::usedAvailableWidthForFloatAvoider):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::InlineFormattingGeometry::logicalTopForNextLine const):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::floatConstraints const):

Canonical link: https://commits.webkit.org/254185@main




More information about the webkit-changes mailing list