[webkit-changes] [WebKit/WebKit] 8ee6f7: [WGSL] Implement parsing for ArrayAccess postfix e...

Dan Glastonbury noreply at github.com
Tue Sep 6 02:08:22 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8ee6f731f76e42891521ff404a1303305679104b
      https://github.com/WebKit/WebKit/commit/8ee6f731f76e42891521ff404a1303305679104b
  Author: Dan Glastonbury <djg at apple.com>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M Source/WebGPU/WGSL/AST/Expression.h
    A Source/WebGPU/WGSL/AST/Expressions/ArrayAccess.h
    M Source/WebGPU/WGSL/Parser.cpp
    M Source/WebGPU/WGSLUnitTests/WGSLParserTests.mm
    M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj

  Log Message:
  -----------
  [WGSL] Implement parsing for ArrayAccess postfix expression.
https://bugs.webkit.org/show_bug.cgi?id=244789
rdar://99557326

Reviewed by Myles Maxfield.

* Source/WebGPU/WGSL/AST/Expression.h:
(WGSL::AST::Expression::isArrayAccess const):
Add kind and predicate for ArrayAccess.
* Source/WebGPU/WGSL/AST/Expressions/ArrayAccess.h: Added.
Implementation of AST::ArrayAccess node.
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser<Lexer>::parsePostfixExpression):
Implement parsing of a sequence of StructureAccess or ArrayAccess postfix to an
expression.
* Source/WebGPU/WGSLUnitTests/WGSLParserTests.mm:
(-[WGSLParserTests testParsingArrayAccess]):
Test parsing of `x[42]`
* Source/WebGPU/WebGPU.xcodeproj/project.pbxproj:
Add 'ArrayAccess.h'

Canonical link: https://commits.webkit.org/254182@main




More information about the webkit-changes mailing list