[webkit-changes] [WebKit/WebKit] b518c5: AX: AXIsolatedObject::associatedAXObject should re...

Tyler Wilcock noreply at github.com
Mon Sep 5 19:49:20 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b518c52e92ccef11730d27c12fd8328959695f79
      https://github.com/WebKit/WebKit/commit/b518c52e92ccef11730d27c12fd8328959695f79
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2022-09-05 (Mon, 05 Sep 2022)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h

  Log Message:
  -----------
  AX: AXIsolatedObject::associatedAXObject should return an AccessibilityObject*
https://bugs.webkit.org/show_bug.cgi?id=244820
rdar://problem/99575303

Reviewed by Chris Fleizach.

The purpose of AXIsolatedObject::associatedAXObject is to return the
live object that corresponds to `this` (an AXIsolatedObject). It never
makes sense for this to be another AXIsolatedObject, so this method
should return an AccessibilityObject*, not an AXCoreObject*.

* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::associatedAXObject const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/AccessibilityObject.h:
Make innerHTML, outerHTML, visibleCharacterRange, and isOnScreen public
since they need to be accessible when called from the corresponding
AXIsolatedObject methods.

Canonical link: https://commits.webkit.org/254172@main




More information about the webkit-changes mailing list