[webkit-changes] [WebKit/WebKit] 29727b: [LFC][IFC] Cleanup InlineFormattingContext::lineLa...

[alan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 29727b096d4842083009e0cfb5af42effb0780c2
      https://github.com/WebKit/WebKit/commit/29727b096d4842083009e0cfb5af42effb0780c2
  Author: Alan Bujtas <zalan at apple.com>
  Date:   2022-09-04 (Sun, 04 Sep 2022)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h

  Log Message:
  -----------
  [LFC][IFC] Cleanup InlineFormattingContext::lineLayout
https://bugs.webkit.org/show_bug.cgi?id=244735

Reviewed by Antti Koivisto.

This in preparation for introducing "skipped" floats (vs. placed floats) where some float boxes can't be placed on the current line.
1. Move some non-essential logic out to InlineFormattingGeometry
2. Remove redundant line range from PreviousLine.
3. Update PreviousLine even when no content was placed on the current line (due to intrusive floats).

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::indexOfFirstInlineItemForNextLine):
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h:
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::InlineFormattingGeometry::logicalTopForNextLine const):
(WebCore::Layout::InlineFormattingGeometry::initialLineHeight const):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:

Canonical link: https://commits.webkit.org/254150@main