[webkit-changes] [WebKit/WebKit] 14ffd2: AX ITM: Stop unnecessarily caching 35 live-tree-on...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 14ffd241d58454d278a0a114cb23e13b17614d81
      https://github.com/WebKit/WebKit/commit/14ffd241d58454d278a0a114cb23e13b17614d81
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2022-09-04 (Sun, 04 Sep 2022)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/AccessibilityObjectInterface.h
    M Source/WebCore/accessibility/AccessibilityTable.h
    M Source/WebCore/accessibility/AccessibilityTableCell.cpp
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h

  Log Message:
  -----------
  AX ITM: Stop unnecessarily caching 35 live-tree-only properties
https://bugs.webkit.org/show_bug.cgi?id=244766
rdar://problem/99531165

Reviewed by Chris Fleizach.

We are currently caching a lot of properties for functions that
are useful only in the context of the live tree. This is wasteful
in terms of CPU and memory. With this patch, those properties are
removed from the AXCoreObject interface and therefore no longer cached
for isolated objects.

* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isSearchField const):
(WebCore::AccessibilityObject::isMediaTimeline const):
(WebCore::AccessibilityObject::isColumnHeaderCell const):
(WebCore::AccessibilityObject::isRowHeaderCell const):
(WebCore::AccessibilityObject::isIncrementor const):
(WebCore::AccessibilityObject::canvasHasFallbackContent const):
(WebCore::AccessibilityObject::speakAsProperty const):
(WebCore::AccessibilityObject::isMathText const):
(WebCore::AccessibilityObject::isMathNumber const):
(WebCore::AccessibilityObject::isMathOperator const):
(WebCore::AccessibilityObject::isMathFenceOperator const):
(WebCore::AccessibilityObject::isMathSeparatorOperator const):
(WebCore::AccessibilityObject::isMathIdentifier const):
(WebCore::AccessibilityObject::webAreaObject const):
* Source/WebCore/accessibility/AccessibilityObjectInterface.h:
* Source/WebCore/accessibility/AccessibilitySlider.h:
* Source/WebCore/accessibility/AccessibilityTable.h:
* Source/WebCore/accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::columnHeaders):
(WebCore::AccessibilityTableCell::rowHeaders):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityValue]):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
(WebCore::AXIsolatedObject::isHovered const): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:

Canonical link: https://commits.webkit.org/254144@main