[webkit-changes] [WebKit/WebKit] bf2449: Expose _overrideDeviceScaleFactor property on iOS ...

Tim Horton noreply at github.com
Sat Sep 3 01:14:04 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bf2449abf730c6c5e867f52040ab28809b01f6a1
      https://github.com/WebKit/WebKit/commit/bf2449abf730c6c5e867f52040ab28809b01f6a1
  Author: Tim Horton <timothy_horton at apple.com>
  Date:   2022-09-03 (Sat, 03 Sep 2022)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
    M Source/WebKit/UIProcess/API/mac/WKView.mm
    M Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/mac/WebViewImpl.h
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm

  Log Message:
  -----------
  Expose _overrideDeviceScaleFactor property on iOS (currently macOS only)
https://bugs.webkit.org/show_bug.cgi?id=244753

Reviewed by Simon Fraser.

Remove our custom implementation of "override the device scale factor"
in WebViewImpl, and make the SPI property call into the "custom device scale factor"
mechanism that GTK folks use on WebPageProxy instead.

Also, expose the property on iOS as well, now that it's not tied to WebViewImpl!

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setOverrideDeviceScaleFactor:]):
(-[WKWebView _overrideDeviceScaleFactor]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
(-[WKWebView _dataTaskWithRequest:completionHandler:]): Deleted.
* Source/WebKit/UIProcess/API/mac/WKView.mm:
(-[WKView _setOverrideDeviceScaleFactor:]):
(-[WKView _overrideDeviceScaleFactor]):
* Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm:
(-[WKWebView _setOverrideDeviceScaleFactor:]): Deleted.
(-[WKWebView _overrideDeviceScaleFactor]): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
(WebKit::WebViewImpl::overrideDeviceScaleFactor const): Deleted.
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::intrinsicDeviceScaleFactor const):
(WebKit::WebViewImpl::setOverrideDeviceScaleFactor): Deleted.

Canonical link: https://commits.webkit.org/254126@main




More information about the webkit-changes mailing list