[webkit-changes] [WebKit/WebKit] 6db9bb: DumpRenderTree does not seem to support PingLoad t...

Brent Fulgham noreply at github.com
Mon Oct 31 15:43:49 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6db9bb4cc51f9fd26437c89e48a570944989bcfb
      https://github.com/WebKit/WebKit/commit/6db9bb4cc51f9fd26437c89e48a570944989bcfb
  Author: Brent Fulgham <bfulgham at apple.com>
  Date:   2022-10-31 (Mon, 31 Oct 2022)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/platform/mac-wk1/TestExpectations
    A LayoutTests/platform/mac-wk1/http/tests/inspector/network/getSerializedCertificate-expected.txt
    A LayoutTests/platform/mac-wk1/http/tests/loading/oauth-expected.txt
    A LayoutTests/platform/mac-wk1/http/tests/security/basic-auth-subresource-expected.txt
    A LayoutTests/platform/mac-wk1/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-https-expected.txt
    A LayoutTests/platform/mac-wk1/http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https-expected.txt
    A LayoutTests/platform/mac-wk1/http/tests/security/contentSecurityPolicy/video-with-https-url-allowed-by-csp-media-src-star-expected.txt
    A LayoutTests/platform/mac-wk1/http/tests/security/mixedContent/insecure-image-redirects-to-basic-auth-secure-image-expected.txt
    A LayoutTests/platform/mac-wk1/http/tests/security/mixedContent/secure-redirect-to-insecure-redirect-to-basic-auth-secure-image.https-expected.txt
    A LayoutTests/platform/mac-wk1/http/tests/security/mixedContent/secure-redirect-to-secure-redirect-to-basic-auth-secure-image.https-expected.txt
    A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/autoplay-allowed-by-feature-policy-attribute-redirect-on-load.https.sub-expected.txt
    A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/autoplay-allowed-by-feature-policy-attribute.https.sub-expected.txt
    A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/autoplay-disabled-by-feature-policy.https.sub-expected.txt
    A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/infrastructure/server/wpt-server-http.sub-expected.txt
    A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/secure-contexts/basic-popup-and-iframe-tests-expected.txt
    M Source/WebCore/page/DeprecatedGlobalSettings.h
    M Source/WebCore/testing/js/WebCoreTestSupport.cpp
    M Source/WebCore/testing/js/WebCoreTestSupport.h
    M Tools/DumpRenderTree/TestRunner.cpp
    M Tools/DumpRenderTree/TestRunner.h
    M Tools/DumpRenderTree/mac/DumpRenderTree.mm
    M Tools/DumpRenderTree/mac/ResourceLoadDelegate.mm

  Log Message:
  -----------
  DumpRenderTree does not seem to support PingLoad to HTTPS
https://bugs.webkit.org/show_bug.cgi?id=246719
<rdar://101040717>

Reviewed by Chris Dumez.

Revise DumpRenderTree to handle ServerTrust protection space evaluations,
and to allow them under the same cases as Modern WebKit.

* LayoutTests/platform/mac-wk1/TestExpectations: Correct some expectations.
* Source/WebCore/page/DeprecatedGlobalSettings.h:
* Source/WebCore/testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::allowsAnySSLCertificate): Added getter to expose state to DRT.
* Source/WebCore/testing/js/WebCoreTestSupport.h:
* Tools/DumpRenderTree/TestRunner.cpp:
(TestRunner::allowsAnySSLCertificate): Added.
* Tools/DumpRenderTree/TestRunner.h:
(TestRunner::allowAnyHTTPSCertificateForAllowedHosts const): Added.
(TestRunner::setAllowAnyHTTPSCertificateForAllowedHosts): Added.
(TestRunner::localhostAliases const): Added.
(TestRunner::setLocalhostAliases): Added.
* Tools/DumpRenderTree/mac/DumpRenderTree.mm:
(initializeGlobalsFromCommandLineOptions): Update to recognize the allowed hosts test runner argument.
(dumpRenderTree):
(runTest):
* Tools/DumpRenderTree/mac/ResourceLoadDelegate.mm:
(canAuthenticateServerTrustAgainstProtectionSpace): Added.
(-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): Updated to behave
the same way as WebKitTestRunner.
(-[ResourceLoadDelegate webView:resource:canAuthenticateAgainstProtectionSpace:forDataSource:]): Added.

Canonical link: https://commits.webkit.org/256173@main




More information about the webkit-changes mailing list