[webkit-changes] [WebKit/WebKit] 247649: [Modern Media Controls] [macOS] REGRESSION(252362 at ...

[Devin Rousso]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2476493a0ed78d8778b5766a92c76f8217b8e228
      https://github.com/WebKit/WebKit/commit/2476493a0ed78d8778b5766a92c76f8217b8e228
  Author: Devin Rousso <drousso at apple.com>
  Date:   2022-10-31 (Mon, 31 Oct 2022)

  Changed paths:
    M Source/WebCore/Modules/modern-media-controls/controls/adwaita-layout-traits.js
    M Source/WebCore/Modules/modern-media-controls/controls/ios-inline-media-controls.css
    M Source/WebCore/Modules/modern-media-controls/controls/ios-layout-traits.js
    M Source/WebCore/Modules/modern-media-controls/controls/layout-traits.js
    M Source/WebCore/Modules/modern-media-controls/controls/macos-layout-traits.js
    M Source/WebCore/Modules/modern-media-controls/controls/media-controls.css
    M Source/WebCore/Modules/modern-media-controls/controls/media-controls.js
    M Source/WebCore/Modules/modern-media-controls/controls/watchos-layout-traits.js

  Log Message:
  -----------
  [Modern Media Controls] [macOS] REGRESSION(252362 at main): adding `border-radius: inherit` causes negative power perf impact
https://bugs.webkit.org/show_bug.cgi?id=247152
<rdar://problem/100234334>

Reviewed by Eric Carlson.

This is only used on iOS, so adding it to all platforms is unnecessary (and apparently costly).

* Source/WebCore/Modules/modern-media-controls/controls/layout-traits.js:
(LayoutTraits.prototype.inheritsBorderRadius): Added.
* Source/WebCore/Modules/modern-media-controls/controls/adwaita-layout-traits.js:
(AdwaitaLayoutTraits.prototype.inheritsBorderRadius): Added.
* Source/WebCore/Modules/modern-media-controls/controls/ios-layout-traits.js:
(IOSLayoutTraits.prototype.inheritsBorderRadius): Added.
* Source/WebCore/Modules/modern-media-controls/controls/macos-layout-traits.js:
(MacOSLayoutTraits.prototype.inheritsBorderRadius): Added.
* Source/WebCore/Modules/modern-media-controls/controls/watchos-layout-traits.js:
(WatchOSLayoutTraits.prototype.inheritsBorderRadius): Added.
* Source/WebCore/Modules/modern-media-controls/controls/media-controls.js:
(MediaControls):
Add a new `LayoutTraits` method that controls whether `border-radius: inherit` is used.

* Source/WebCore/Modules/modern-media-controls/controls/ios-inline-media-controls.css:
(.media-controls.inline.ios:not(.audio)):
* Source/WebCore/Modules/modern-media-controls/controls/media-controls.css:
(.media-controls-container):
(.media-controls-container:has(.media-controls.inherits-border-radius), .media-controls.inherits-border-radius): Added.
Move the `border-radius: inherit` to only if the CSS class is applied (which is controlled by the above).

Canonical link: https://commits.webkit.org/256167@main