[webkit-changes] [WebKit/WebKit] b12482: [JSC] Fix WebAssembly.Tag.getArg's thrown error type

Yusuke Suzuki noreply at github.com
Mon Oct 31 10:50:44 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b1248207241a66f6361f4a2f035f18cc7caed4ae
      https://github.com/WebKit/WebKit/commit/b1248207241a66f6361f4a2f035f18cc7caed4ae
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2022-10-31 (Mon, 31 Oct 2022)

  Changed paths:
    M JSTests/wasm/stress/create-tag-from.js
    M JSTests/wasm/v8/exceptions-api.js
    M LayoutTests/imported/w3c/web-platform-tests/wasm/compile_worker.js
    M LayoutTests/imported/w3c/web-platform-tests/wasm/create_multiple_memory.worker.js
    M LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/exception/getArg.tentative.any.js
    M LayoutTests/imported/w3c/web-platform-tests/wasm/resources/load_wasm.js
    M LayoutTests/imported/w3c/web-platform-tests/wasm/webapi/origin.sub.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/wasm/webapi/origin.sub.any.js
    M LayoutTests/imported/w3c/web-platform-tests/wasm/webapi/origin.sub.any.worker-expected.txt
    A LayoutTests/platform/glib/imported/w3c/web-platform-tests/wasm/webapi/origin.sub.any-expected.txt
    A LayoutTests/platform/glib/imported/w3c/web-platform-tests/wasm/webapi/origin.sub.any.worker-expected.txt
    M Source/JavaScriptCore/wasm/js/WebAssemblyExceptionPrototype.cpp

  Log Message:
  -----------
  [JSC] Fix WebAssembly.Tag.getArg's thrown error type
https://bugs.webkit.org/show_bug.cgi?id=247223
rdar://101705666

Reviewed by Alexey Shvayka.

1. We should use toNonWrappingUint32 to get Uint32 for getArg index
2. We should throw RangeError instead of TypeError for out of bounds getArg

https://webassembly.github.io/exception-handling/js-api/#dom-exception-getarg

* LayoutTests/imported/w3c/web-platform-tests/wasm/compile_worker.js:
* LayoutTests/imported/w3c/web-platform-tests/wasm/create_multiple_memory.worker.js:
* LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/exception/getArg.tentative.any.js:
(test):
* LayoutTests/imported/w3c/web-platform-tests/wasm/resources/load_wasm.js:
* LayoutTests/imported/w3c/web-platform-tests/wasm/webapi/origin.sub.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/wasm/webapi/origin.sub.any.js:
* LayoutTests/imported/w3c/web-platform-tests/wasm/webapi/origin.sub.any.worker-expected.txt:
* Source/JavaScriptCore/wasm/js/WebAssemblyExceptionPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::getTag): Deleted.

Canonical link: https://commits.webkit.org/256158@main




More information about the webkit-changes mailing list