[webkit-changes] [WebKit/WebKit] 2419e9: Style checker has issue with test implementation f...
Kimmo Kinnunen
noreply at github.com
Sat Oct 29 00:42:15 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2419e966a284c22a483f6f9bdc02141bed8e0c29
https://github.com/WebKit/WebKit/commit/2419e966a284c22a483f6f9bdc02141bed8e0c29
Author: Kimmo Kinnunen <kkinnunen at apple.com>
Date: 2022-10-29 (Sat, 29 Oct 2022)
Changed paths:
M Tools/Scripts/webkitpy/style/checkers/cpp.py
M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Log Message:
-----------
Style checker has issue with test implementation files with no primary headers
https://bugs.webkit.org/show_bug.cgi?id=185057
rdar://problem/101670878
Reviewed by Jonathan Bedard.
Fix the cpp style checker to account for test .cpp files. These
files do not have a primary header file. The style checker would
make many mistakes flagging a wrong include as primary include.
For file ConnectionTests.cpp:
- It would think "Connection.h" would be a primary include.
- It would think "Test.h" would be a primary include.
* Tools/Scripts/webkitpy/style/checkers/cpp.py:
(_classify_include):
* Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:
Canonical link: https://commits.webkit.org/256128@main
More information about the webkit-changes
mailing list