[webkit-changes] [WebKit/WebKit] 2946bb: Allow calc() with combined percentages and lengths...

[Darin Adler]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2946bb7fba02b40105f29744a1600ec192b59a78
      https://github.com/WebKit/WebKit/commit/2946bb7fba02b40105f29744a1600ec192b59a78
  Author: Darin Adler <darin at apple.com>
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
    M LayoutTests/css3/calc/line-height-expected.txt
    A LayoutTests/fast/css/calc-with-percent-and-number-in-line-height-crash-expected.txt
    A LayoutTests/fast/css/calc-with-percent-and-number-in-line-height-crash.html
    A LayoutTests/fast/css/line-height-1-expected.html
    A LayoutTests/fast/css/line-height-1.html
    A LayoutTests/fast/css/line-height-2-expected.html
    A LayoutTests/fast/css/line-height-2.html
    A LayoutTests/fast/css/line-height-basics-expected.txt
    A LayoutTests/fast/css/line-height-basics.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-computed-expected.txt
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  Allow calc() with combined percentages and lengths for line-height
https://bugs.webkit.org/show_bug.cgi?id=247007
rdar://problem/101546260

Reviewed by Tim Nguyen and Sam Weinig.

* LayoutTests/css3/calc/line-height-expected.txt: Expect PASS.

* LayoutTests/fast/css/calc-with-percent-and-number-in-line-height-crash-expected.txt: Added.
* LayoutTests/fast/css/calc-with-percent-and-number-in-line-height-crash.html: Added.
Adopted this test from Chromium.

* LayoutTests/fast/css/line-height-1-expected.html: Added.
* LayoutTests/fast/css/line-height-1.html: Added.
* LayoutTests/fast/css/line-height-2-expected.html: Added.
* LayoutTests/fast/css/line-height-2.html: Added.
Adopted these tests from Mozilla.

* LayoutTests/fast/css/line-height-basics-expected.txt: Added.
* LayoutTests/fast/css/line-height-basics.html: Added.
Adopted this test from Chromium.

* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-computed-expected.txt:
Expected many more PASS.

* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertLineHeight): Allow percentage combined with length.

Canonical link: https://commits.webkit.org/256095@main