[webkit-changes] [WebKit/WebKit] 624a8e: WKNavigationAction should expose _WKHitTestResult

Jeff Miller noreply at github.com
Wed Oct 26 15:59:00 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 624a8e752b7108e9a5f547a6dc9bc432f41c501f
      https://github.com/WebKit/WebKit/commit/624a8e752b7108e9a5f547a6dc9bc432f41c501f
  Author: Jeff Miller <jeffm at apple.com>
  Date:   2022-10-26 (Wed, 26 Oct 2022)

  Changed paths:
    M Source/WebKit/Shared/NavigationActionData.cpp
    M Source/WebKit/Shared/NavigationActionData.h
    M Source/WebKit/UIProcess/API/APINavigationAction.h
    M Source/WebKit/UIProcess/API/Cocoa/WKNavigationAction.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKNavigationActionPrivate.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm

  Log Message:
  -----------
  WKNavigationAction should expose _WKHitTestResult
https://bugs.webkit.org/show_bug.cgi?id=246539
<rdar://100526247>

Reviewed by Alex Christensen.

Add a _hitTestResult property to WKNavigationAction. This property can be nil.

* Source/WebKit/Shared/NavigationActionData.cpp:
(WebKit::NavigationActionData::encode const):
Encode webHitTestResultData.

(WebKit::NavigationActionData::decode):
Decode webHitTestResultData.

* Source/WebKit/Shared/NavigationActionData.h:
Add an optional webHitTestResultData.

* Source/WebKit/UIProcess/API/APINavigationAction.h:
Add webHitTestResultData().

* Source/WebKit/UIProcess/API/Cocoa/WKNavigationAction.mm:
(-[WKNavigationAction _hitTestResult]):
Added.

* Source/WebKit/UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
Added _hitTestResult property.

* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::setWebHitTestResultDataInNavigationActionDataIfNecessary):
Added. Sets navigationActionData.webHitTestResultData if there is associated mouse event data.

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
Set navigationActionData.webHitTestResultData if necessary.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
Add _hitTestResult tests to tests that generate mouse event data. The only data that's populated in
_hitTestResult is the elementBoundingBox, so verify that it's not empty.

Canonical link: https://commits.webkit.org/256038@main




More information about the webkit-changes mailing list