[webkit-changes] [WebKit/WebKit] 1d29cf: Omit "normal" value for line-height from font shor...

Darin Adler noreply at github.com
Tue Oct 25 16:52:03 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1d29cf3005f231fece1da7a0d02bf3909bda65d1
      https://github.com/WebKit/WebKit/commit/1d29cf3005f231fece1da7a0d02bf3909bda65d1
  Author: Darin Adler <darin at apple.com>
  Date:   2022-10-25 (Tue, 25 Oct 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-valid-expected.txt
    M Source/WebCore/css/parser/CSSPropertyParser.cpp

  Log Message:
  -----------
  Omit "normal" value for line-height from font shorthand in specified style too, not just computed
https://bugs.webkit.org/show_bug.cgi?id=246931
rdar://problem/101487839

Reviewed by Tim Nguyen.

* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-valid-expected.txt:
Expect more cases to pass.

* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::consumeFont): If the keyword normal appears, treat that as if no line
height was specified, rather than as a line height value.

Canonical link: https://commits.webkit.org/255993@main




More information about the webkit-changes mailing list