[webkit-changes] [WebKit/WebKit] 62dfaa: Creating a shared worker connection should retry w...

youennf noreply at github.com
Tue Oct 25 10:24:18 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62dfaac6890ce80be23c8d0189e5f59df86bb3a5
      https://github.com/WebKit/WebKit/commit/62dfaac6890ce80be23c8d0189e5f59df86bb3a5
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2022-10-25 (Tue, 25 Oct 2022)

  Changed paths:
    M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp

  Log Message:
  -----------
  Creating a shared worker connection should retry without providing a specific webprocess
https://bugs.webkit.org/show_bug.cgi?id=246999
rdar://101506812

Reviewed by Chris Dumez.

We were trying to create a context connection of a shared worker by always sending a particular target process.
If this process is terminated for instance, the network process will think that the connection should be there.
But no context connection is there, so it retries to create a context connection, with the same target process.
This triggers a loop.
To break the loop, we try using the first target process on the first try but not on successive tries.
UIProcess, on second try, will then try some other processes, typically by creating a new process.

* Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp:
(WebKit::WebSharedWorkerServer::createContextConnection):

Canonical link: https://commits.webkit.org/255968@main




More information about the webkit-changes mailing list