[webkit-changes] [WebKit/WebKit] e868bf: [CMake] All post-commit buildbots should build wit...

Michael Catanzaro noreply at github.com
Tue Oct 25 06:38:13 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e868bfe3d84531d77d21eecc5f67c27aee1bb503
      https://github.com/WebKit/WebKit/commit/e868bfe3d84531d77d21eecc5f67c27aee1bb503
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2022-10-25 (Tue, 25 Oct 2022)

  Changed paths:
    M Tools/CISupport/build-webkit-org/steps.py
    M Tools/CISupport/build-webkit-org/steps_unittest.py

  Log Message:
  -----------
  [CMake] All post-commit buildbots should build with --no-fatal-warnings
https://bugs.webkit.org/show_bug.cgi?id=246760

Reviewed by Jonathan Bedard.

We need to enable fatal warnings on EWS to prevent developers from
introducing new warnings. But we do not want fatal warnings on
post-commit bots, since that may result in lost test results, which
would be a very harsh price to pay for an unused variable or whatnot.

Note this is not needed for the JSC bots since those do not use
ENABLE_DEVELOPER_MODE.

* Tools/CISupport/build-webkit-org/steps.py:
(CompileWebKit):
* Tools/CISupport/build-webkit-org/steps_unittest.py:
(TestCompileWebKit.test_success):
(TestCompileWebKit.test_success_gtk):
(TestCompileWebKit.test_success_wpe):
(TestCompileWebKit.test_failure):

Canonical link: https://commits.webkit.org/255954@main




More information about the webkit-changes mailing list