[webkit-changes] [WebKit/WebKit] 3c1ac0: [iOS] Add a warning banner upon entering element f...

Jer Noble noreply at github.com
Mon Oct 24 10:15:02 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3c1ac0d1fc163cdbcebc60329bef12353a00208c
      https://github.com/WebKit/WebKit/commit/3c1ac0d1fc163cdbcebc60329bef12353a00208c
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2022-10-24 (Mon, 24 Oct 2022)

  Changed paths:
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm

  Log Message:
  -----------
  [iOS] Add a warning banner upon entering element fullscreen
https://bugs.webkit.org/show_bug.cgi?id=246872
rdar://101435275

Reviewed by Eric Carlson.

Add a warning banner to the element fullscreen implementation which appears after the fullscreen animation
completes, disappears shortly afterwards, and re-appears after a background fullscreen webview is foregrounded.

* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h:
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[_WKInsetLabel drawTextInRect:]):
(-[_WKInsetLabel intrinsicContentSize]):
(-[WKFullScreenViewController invalidate]):
(-[WKFullScreenViewController dealloc]):
(-[WKFullScreenViewController showBanner]):
(-[WKFullScreenViewController hideBanner]):
(-[WKFullScreenViewController location]):
(-[WKFullScreenViewController setLocation:]):
(-[WKFullScreenViewController loadView]):
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController initWithWebView:]):
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController _applicationDidBecomeActive:]):

Canonical link: https://commits.webkit.org/255921@main




More information about the webkit-changes mailing list