[webkit-changes] [WebKit/WebKit] 1610fc: [web-animations] commitStyles() fails to commit a ...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1610fc7268379c03a2abe302dd3982787de6ee0f
      https://github.com/WebKit/WebKit/commit/1610fc7268379c03a2abe302dd3982787de6ee0f
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2022-10-24 (Mon, 24 Oct 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/commitStyles-expected.txt
    M Source/WebCore/css/ComputedStyleExtractor.cpp

  Log Message:
  -----------
  [web-animations] commitStyles() fails to commit a relative line-height value
https://bugs.webkit.org/show_bug.cgi?id=246914

Reviewed by Antti Koivisto.

When Animation.commitStyles() is called, we commit animated values to the target element's inline style. In the
case of "line-height" we must commit a relative value if one was specified, such that changing the font-size
after committing will adjust the line-height accordingly.

When extracting the value from commitStyles() where the "valueType" is set to "Computed", such as when a
ComputedStyleExtractor is used in that method, we look for a relative "line-height" and return that value.

* LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/commitStyles-expected.txt:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::optionalLineHeight):
(WebCore::lineHeight):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

Canonical link: https://commits.webkit.org/255912@main