[webkit-changes] [WebKit/WebKit] b4421d: Handle <attachment> painting in GPUP

Nikos Mouchtaris noreply at github.com
Sun Oct 23 19:31:51 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b4421d4a471ca4a0d2c02b67713a81380c441725
      https://github.com/WebKit/WebKit/commit/b4421d4a471ca4a0d2c02b67713a81380c441725
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2022-10-23 (Sun, 23 Oct 2022)

  Changed paths:
    A LayoutTests/fast/attachment/mac/attachment-element-gpu-process-expected.html
    A LayoutTests/fast/attachment/mac/attachment-element-gpu-process.html
    M Source/WebCore/SourcesCocoa.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    A Source/WebCore/rendering/AttachmentLayout.h
    A Source/WebCore/rendering/AttachmentLayout.mm
    M Source/WebCore/rendering/RenderTheme.cpp
    M Source/WebCore/rendering/RenderTheme.h
    M Source/WebCore/rendering/RenderThemeCocoa.h
    M Source/WebCore/rendering/RenderThemeCocoa.mm
    M Source/WebCore/rendering/RenderThemeIOS.h
    M Source/WebCore/rendering/RenderThemeIOS.mm
    M Source/WebCore/rendering/RenderThemeMac.h
    M Source/WebCore/rendering/RenderThemeMac.mm

  Log Message:
  -----------
  Handle <attachment> painting in GPUP
https://bugs.webkit.org/show_bug.cgi?id=246368
rdar://83459796

Reviewed by Simon Fraser.

Unify some parts of layout/painting of attachment on mac and ios.
This includes the struct containing layout info of the attachment
element, the functions constructing the lines of the subtitle and
title, painting of the lines. Move the bits constructing the
layout struct out of RenderThemeMac/iOS into AttachmentLayout.

* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::AttachmentLayout::layOutSubtitle):
(WebCore::paintAttachmentIcon):
(WebCore::drawCTLine):
(WebCore::paintAttachmentTitle):
(WebCore::paintAttachmentSubtitle):

Canonical link: https://commits.webkit.org/255903@main




More information about the webkit-changes mailing list