[webkit-changes] [WebKit/WebKit] 5e7565: [LFC][IFC] Add support for "line-box-contain: font"

Alan Baradlay noreply at github.com
Sun Oct 23 08:11:29 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5e7565912789002ab666837e878f52615810564f
      https://github.com/WebKit/WebKit/commit/5e7565912789002ab666837e878f52615810564f
  Author: Alan Bujtas <zalan at apple.com>
  Date:   2022-10-23 (Sun, 23 Oct 2022)

  Changed paths:
    M LayoutTests/platform/ios/fast/block/lineboxcontain/font-replaced-expected.txt
    M LayoutTests/platform/mac/fast/block/lineboxcontain/font-replaced-expected.txt
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h
    M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp

  Log Message:
  -----------
  [LFC][IFC] Add support for "line-box-contain: font"
https://bugs.webkit.org/show_bug.cgi?id=246896

Reviewed by Antti Koivisto.

Inline boxes should contribute with their font based metrics to line box height (when they have content).

* LayoutTests/platform/mac/fast/block/lineboxcontain/font-replaced-expected.txt: Content is not supposed to be scrollable.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::InlineFormattingGeometry::inlineLevelBoxAffectsLineBox const): Move lineBoxContain functionality over to InlineLevelBox.
* Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:
(WebCore::Layout::InlineLevelBox::isPreferredLineHeightFontMetricsBased const):
(WebCore::Layout::m_style):
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForStyle):

Canonical link: https://commits.webkit.org/255895@main




More information about the webkit-changes mailing list