[webkit-changes] [WebKit/WebKit] 0acf24: text-combine-upright text-shadow is not correctly ...

Tim Nguyen noreply at github.com
Sun Oct 23 00:02:47 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0acf2457faa716438f87f4446a13b3da6a35be0f
      https://github.com/WebKit/WebKit/commit/0acf2457faa716438f87f4446a13b3da6a35be0f
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2022-10-23 (Sun, 23 Oct 2022)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/text-combine-upright-shadow-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/text-combine-upright-shadow-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/text-combine-upright-shadow.html
    M Source/WebCore/rendering/TextPainter.cpp

  Log Message:
  -----------
  text-combine-upright text-shadow is not correctly positioned
https://bugs.webkit.org/show_bug.cgi?id=112655
rdar://101467340

Reviewed by Simon Fraser and Darin Adler.

* Source/WebCore/rendering/TextPainter.cpp:
(WebCore::TextPainter::paintTextWithShadows): Treat combined text as horizontal text when painting shadows.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/text-combine-upright-shadow-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/text-combine-upright-shadow-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/text-combine-upright-shadow.html: Added.

Canonical link: https://commits.webkit.org/255892@main




More information about the webkit-changes mailing list