[webkit-changes] [WebKit/WebKit] 806c01: caretRangeFromPoint returns bad results near input...

Ahmad Saleem noreply at github.com
Sat Oct 22 15:53:21 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 806c01fc86610107ae8f924a26bbe7f093ce4a9a
      https://github.com/WebKit/WebKit/commit/806c01fc86610107ae8f924a26bbe7f093ce4a9a
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-10-22 (Sat, 22 Oct 2022)

  Changed paths:
    A LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-strict-mode-wtih-checkbox-expected.txt
    A LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-strict-mode-wtih-checkbox.html
    M Source/WebCore/rendering/RenderBlock.cpp

  Log Message:
  -----------
  caretRangeFromPoint returns bad results near input type checkbox or radio in Strict Mode

caretRangeFromPoint returns bad results near input type checkbox or radio in Strict Mode
https://bugs.webkit.org/show_bug.cgi?id=246892

Reviewed by Ryosuke Niwa.

Merge - https://src.chromium.org/viewvc/blink?view=revision&revision=157506

This patch changes RenderBlock::positionForPoint() to check out of bound position. When document is no quirk mode, RenderBlock::positionForPoint() gets a position which is out side of RenderBlock due by condition in RenderBlock::positionForPointWithInlineChildren().

* Source/WebCore/rendering/RenderBlock.cpp:
(RenderBlock::positionForPoint): Add Out of Bound checks
* LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-strict-mode-with-checkbox.html: Added Test Case
* LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-strict-mode-with-checkbox-expected.txt: Added Test Case Expectations

Canonical link: https://commits.webkit.org/255886@main




More information about the webkit-changes mailing list