[webkit-changes] [WebKit/WebKit] 00db99: font-weight should be clamped to 1 as minimum

Darin Adler noreply at github.com
Sat Oct 22 09:00:05 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 00db99db9acfe127589e95787d0b8923146676a9
      https://github.com/WebKit/WebKit/commit/00db99db9acfe127589e95787d0b8923146676a9
  Author: Darin Adler <darin at apple.com>
  Date:   2022-10-22 (Sat, 22 Oct 2022)

  Changed paths:
    M LayoutTests/fast/text/font-weight-parse-expected.txt
    M LayoutTests/fast/text/font-weight-parse.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/font-shorthand-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/font-weight-parsing-expected.txt
    R LayoutTests/platform/gtk/fast/text/font-weight-parse-expected.txt
    R LayoutTests/platform/ios/fast/text/font-weight-parse-expected.txt
    R LayoutTests/platform/mac/fast/text/font-weight-parse-expected.txt
    R LayoutTests/platform/wpe/fast/text/font-weight-parse-expected.txt
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp

  Log Message:
  -----------
  font-weight should be clamped to 1 as minimum
https://bugs.webkit.org/show_bug.cgi?id=246575
rdar://problem/101441591

Reviewed by Tim Nguyen.

* LayoutTests/fast/text/font-weight-parse-expected.txt: Updated to expect PASS.
* LayoutTests/fast/text/font-weight-parse.html: Changed to expect a minimum of 1 rather than of 0.

* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/font-shorthand-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/font-weight-parsing-expected.txt:
Updated to expect more PASS.

* LayoutTests/platform/gtk/fast/text/font-weight-parse-expected.txt: Removed.
* LayoutTests/platform/ios/fast/text/font-weight-parse-expected.txt: Removed.
* LayoutTests/platform/mac/fast/text/font-weight-parse-expected.txt: Removed.
* LayoutTests/platform/wpe/fast/text/font-weight-parse-expected.txt: Removed.

* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeFontWeightNumberRaw): Clamp to [1,1000].

Canonical link: https://commits.webkit.org/255873@main




More information about the webkit-changes mailing list