[webkit-changes] [WebKit/WebKit] 03b3e7: AsyncScrolling: add ScrollingTreeOverflowScrollPro...

Carlos Garcia Campos noreply at github.com
Sat Oct 22 01:14:39 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 03b3e7f3ada39b999913703406b57eb2b17208e4
      https://github.com/WebKit/WebKit/commit/03b3e7f3ada39b999913703406b57eb2b17208e4
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2022-10-22 (Sat, 22 Oct 2022)

  Changed paths:
    M Source/WebCore/PlatformMac.cmake
    M Source/WebCore/PlatformPlayStation.cmake
    M Source/WebCore/Sources.txt
    M Source/WebCore/SourcesCocoa.txt
    M Source/WebCore/SourcesGTK.txt
    M Source/WebCore/SourcesWPE.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/page/scrolling/ScrollingTreeNode.h
    A Source/WebCore/page/scrolling/ScrollingTreeOverflowScrollProxyNode.cpp
    A Source/WebCore/page/scrolling/ScrollingTreeOverflowScrollProxyNode.h
    R Source/WebCore/page/scrolling/cocoa/ScrollingTreeOverflowScrollProxyNode.h
    R Source/WebCore/page/scrolling/cocoa/ScrollingTreeOverflowScrollProxyNode.mm
    A Source/WebCore/page/scrolling/cocoa/ScrollingTreeOverflowScrollProxyNodeCocoa.h
    A Source/WebCore/page/scrolling/cocoa/ScrollingTreeOverflowScrollProxyNodeCocoa.mm
    M Source/WebCore/page/scrolling/mac/ScrollingTreeMac.mm
    M Source/WebCore/page/scrolling/nicosia/ScrollingTreeNicosia.cpp
    R Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNode.cpp
    R Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNode.h
    A Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNodeNicosia.cpp
    A Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNodeNicosia.h
    M Source/WebCore/page/scrolling/nicosia/ScrollingTreeStickyNodeNicosia.cpp
    M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp

  Log Message:
  -----------
  AsyncScrolling: add ScrollingTreeOverflowScrollProxyNode base class
https://bugs.webkit.org/show_bug.cgi?id=246849

Reviewed by Simon Fraser.

Make cocoa and nicosia implementations inherit from it and move all the common code there

* Source/WebCore/PlatformMac.cmake:
* Source/WebCore/PlatformPlayStation.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/SourcesGTK.txt:
* Source/WebCore/SourcesWPE.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::isOverflowScrollProxyNodeCocoa const):
(WebCore::ScrollingTreeNode::isOverflowScrollProxyNodeNicosia const):
* Source/WebCore/page/scrolling/ScrollingTreeOverflowScrollProxyNode.cpp: Renamed from Source/WebCore/page/scrolling/cocoa/ScrollingTreeOverflowScrollProxyNode.mm.
(WebCore::ScrollingTreeOverflowScrollProxyNode::ScrollingTreeOverflowScrollProxyNode):
(WebCore::ScrollingTreeOverflowScrollProxyNode::commitStateBeforeChildren):
(WebCore::ScrollingTreeOverflowScrollProxyNode::scrollDeltaSinceLastCommit const):
(WebCore::ScrollingTreeOverflowScrollProxyNode::computeLayerPosition const):
(WebCore::ScrollingTreeOverflowScrollProxyNode::dumpProperties const):
* Source/WebCore/page/scrolling/ScrollingTreeOverflowScrollProxyNode.h: Copied from Source/WebCore/page/scrolling/cocoa/ScrollingTreeOverflowScrollProxyNode.h.
(WebCore::ScrollingTreeOverflowScrollProxyNode::overflowScrollingNodeID const):
* Source/WebCore/page/scrolling/cocoa/ScrollingTreeOverflowScrollProxyNodeCocoa.h: Renamed from Source/WebCore/page/scrolling/cocoa/ScrollingTreeOverflowScrollProxyNode.h.
* Source/WebCore/page/scrolling/cocoa/ScrollingTreeOverflowScrollProxyNodeCocoa.mm: Added.
(WebCore::ScrollingTreeOverflowScrollProxyNodeCocoa::create):
(WebCore::ScrollingTreeOverflowScrollProxyNodeCocoa::ScrollingTreeOverflowScrollProxyNodeCocoa):
(WebCore::ScrollingTreeOverflowScrollProxyNodeCocoa::commitStateBeforeChildren):
(WebCore::ScrollingTreeOverflowScrollProxyNodeCocoa::applyLayerPositions):
* Source/WebCore/page/scrolling/mac/ScrollingTreeMac.mm:
(ScrollingTreeMac::createScrollingTreeNode):
* Source/WebCore/page/scrolling/nicosia/ScrollingTreeNicosia.cpp:
(WebCore::ScrollingTreeNicosia::createScrollingTreeNode):
* Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNode.cpp: Removed.
* Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNodeNicosia.cpp: Added.
(WebCore::ScrollingTreeOverflowScrollProxyNodeNicosia::create):
(WebCore::ScrollingTreeOverflowScrollProxyNodeNicosia::ScrollingTreeOverflowScrollProxyNodeNicosia):
(WebCore::ScrollingTreeOverflowScrollProxyNodeNicosia::commitStateBeforeChildren):
(WebCore::ScrollingTreeOverflowScrollProxyNodeNicosia::applyLayerPositions):
* Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNodeNicosia.h: Renamed from Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNode.h.
* Source/WebCore/page/scrolling/nicosia/ScrollingTreeStickyNodeNicosia.cpp:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp:
(WebKit::RemoteScrollingTree::createScrollingTreeNode):

Canonical link: https://commits.webkit.org/255867@main




More information about the webkit-changes mailing list