[webkit-changes] [WebKit/WebKit] 705266: [web-animations] updating timing should invalidate...

Antoine Quint noreply at github.com
Fri Oct 21 22:23:11 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 705266f62fe851ee4294db050faf6714495ee1ef
      https://github.com/WebKit/WebKit/commit/705266f62fe851ee4294db050faf6714495ee1ef
  Author: Antoine Quint <graouts at apple.com>
  Date:   2022-10-21 (Fri, 21 Oct 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation-expected.txt
    M Source/WebCore/animation/KeyframeEffect.cpp

  Log Message:
  -----------
  [web-animations] updating timing should invalidate the effect
https://bugs.webkit.org/show_bug.cgi?id=246865

Reviewed by Dean Jackson.

Since timing properties affect how the effect value is computed, we need to invalidate
the effect when those properties change. It's pretty amazing that this wasn't caught by
an existing WPT, but implementing iterationComposite surfaced that issue.

* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation-expected.txt:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::animationDidChangeTimingProperties):

Canonical link: https://commits.webkit.org/255863@main




More information about the webkit-changes mailing list