[webkit-changes] [WebKit/WebKit] 85e288: [web-animations] account for iterationComposite wh...
Antoine Quint
noreply at github.com
Fri Oct 21 10:17:06 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 85e288f3ba3e5ec763a6e16e00cde171ba1bdab3
https://github.com/WebKit/WebKit/commit/85e288f3ba3e5ec763a6e16e00cde171ba1bdab3
Author: Antoine Quint <graouts at apple.com>
Date: 2022-10-21 (Fri, 21 Oct 2022)
Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/iterationComposite-expected.txt
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/animation/KeyframeEffect.h
Log Message:
-----------
[web-animations] account for iterationComposite when blending
https://bugs.webkit.org/show_bug.cgi?id=246855
Reviewed by Dean Jackson.
We now account for the iterationComposite property when blending. To do so, we need to also pass the
currentIteration from the computed timing down to KeyframeEffect::setAnimatedPropertiesInStyle().
A number of tests in web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation.html
still fail because we clip intermediate accumulated values in flight. This will need to be looked at
in future patches.
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/iterationComposite-expected.txt:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::apply):
(WebCore::KeyframeEffect::getAnimatedStyle):
(WebCore::KeyframeEffect::setAnimatedPropertiesInStyle):
(WebCore::KeyframeEffect::applyPendingAcceleratedActions):
* Source/WebCore/animation/KeyframeEffect.h:
Canonical link: https://commits.webkit.org/255834@main
More information about the webkit-changes
mailing list