[webkit-changes] [WebKit/WebKit] e23c41: IPC::Connection cannot be bound to arbitrary run loop

Kimmo Kinnunen noreply at github.com
Thu Oct 20 19:41:53 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e23c41101c83695756b09b8741c7529e7b007212
      https://github.com/WebKit/WebKit/commit/e23c41101c83695756b09b8741c7529e7b007212
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2022-10-20 (Thu, 20 Oct 2022)

  Changed paths:
    M Source/WebKit/Platform/IPC/Connection.cpp
    M Source/WebKit/Platform/IPC/Connection.h
    M Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp

  Log Message:
  -----------
  IPC::Connection cannot be bound to arbitrary run loop
https://bugs.webkit.org/show_bug.cgi?id=246336
rdar://problem/101030022

Reviewed by Chris Dumez.

Make it possible to bind IPC::Connection::Client to a particular
run loop via Connection::open(Client&, RunLoop&). The messages
will be dispatched to the passed run loop.

* Source/WebKit/Platform/IPC/Connection.cpp:
(IPC::Connection::SyncMessageState::runLoop):
(IPC::Connection::Connection):
(IPC::Connection::~Connection):
(IPC::Connection::connection):
(IPC::Connection::open):
(IPC::Connection::invalidate):
(IPC::Connection::waitForMessage):
(IPC::Connection::sendSyncMessage):
(IPC::Connection::connectionDidClose):
(IPC::Connection::dispatchSyncMessage):
(IPC::Connection::dispatchDidReceiveInvalidMessage):
(IPC::Connection::dispatchDidCloseAndInvalidate):
(IPC::Connection::enqueueIncomingMessage):
(IPC::Connection::dispatchMessage):
(IPC::Connection::dispatchSyncStateMessages):
(IPC::Connection::dispatchIncomingMessages):
(IPC::Connection::wakeUpRunLoop):
(IPC::Connection::dispatchClient):
(IPC::Connection::postConnectionDidCloseOnConnectionWorkQueue): Deleted.
* Source/WebKit/Platform/IPC/Connection.h:
(IPC::Connection::sendSync):
(IPC::Connection::waitForAndDispatchImmediately):
(IPC::Connection::waitForAsyncCallbackAndDispatchImmediately):
* Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp:
(TestWebKitAPI::TEST_P):

Canonical link: https://commits.webkit.org/255814@main




More information about the webkit-changes mailing list