[webkit-changes] [WebKit/WebKit] 037ca4: [IFC][Integration] Move inline content dimension u...
Alan Baradlay
noreply at github.com
Thu Oct 20 13:48:51 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 037ca440c5c2b37eb7677af16d6c726cb8163aa4
https://github.com/WebKit/WebKit/commit/037ca440c5c2b37eb7677af16d6c726cb8163aa4
Author: Alan Bujtas <zalan at apple.com>
Date: 2022-10-20 (Thu, 20 Oct 2022)
Changed paths:
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h
M Source/WebCore/rendering/RenderBlockFlow.cpp
Log Message:
-----------
[IFC][Integration] Move inline content dimension update from RenderBlockFlow to LineLayout
https://bugs.webkit.org/show_bug.cgi?id=246815
Reviewed by Antti Koivisto.
This ensures that when preferred width computation and line layout are in synch with updating the layout boxes' dimensions.
(Out of sync can lead to inconsistent state where line layout relies on certain structures (BoxGeometry) which are supposed to be constructed by whoever runs layout first (preferred width or actual line layout)).
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateInlineContentDimensions):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutModernLines):
(WebCore::RenderBlockFlow::tryComputePreferredWidthsUsingModernPath):
Canonical link: https://commits.webkit.org/255800@main
More information about the webkit-changes
mailing list